Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(store-sync): add lru cache to recs encode/decode entity #2808

Merged
merged 2 commits into from
May 10, 2024
Merged

feat(store-sync): add lru cache to recs encode/decode entity #2808

merged 2 commits into from
May 10, 2024

Conversation

holic
Copy link
Member

@holic holic commented May 10, 2024 •
edited
Loading

spotted this as a source of heavy computation during hydration of sky strife

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 10, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 4e31232

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@holic holic marked this pull request as ready for review May 10, 2024 10:53
@holic holic requested review from alvrs and yonadaa as code owners May 10, 2024 10:53
@holic holic force-pushed the holic/decode-entity-cache branch from 79a40b9 to d51b2b9 Compare May 10, 2024 10:55
@holic holic force-pushed the holic/decode-entity-cache branch from 82bb795 to 4e31232 Compare May 10, 2024 11:06
@holic holic changed the title feat(store-sync): add lru cache to decodeEntity feat(store-sync): add lru cache to recs encode/decode entity May 10, 2024
@holic holic merged commit a3f8d77 into main May 10, 2024
13 checks passed
@holic holic deleted the holic/decode-entity-cache branch May 10, 2024 11:22
holic added a commit that referenced this pull request May 10, 2024
@holic
docs(store-sync): add changeset for #2808
3aa3390
@holic holic mentioned this pull request May 10, 2024
Merged
holic added a commit that referenced this pull request May 10, 2024
@holic
docs(store-sync): add changeset for #2808 (#2809)
36e1f76
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvrs alvrs alvrs approved these changes

@yonadaa yonadaa Awaiting requested review from yonadaa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@holic @alvrs