-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade to ejs 3.1.10 #2786
Conversation
🦋 Changeset detectedLatest commit: d4ec425 The changes in this PR will be included in the next version bump. This PR includes changesets to release 24 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
packages/store/package.json
Outdated
@@ -76,7 +76,7 @@ | |||
"@types/mocha": "^9.1.1", | |||
"@types/node": "^18.15.11", | |||
"ds-test": "https://github.com/dapphub/ds-test.git#e282159d5170298eb2455a6c05280ab5a73a4ef0", | |||
"ejs": "^3.1.8", | |||
"ejs": "^3.1.10", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is used in store, world cli, and world-modules? wonder if we can safely remove
.changeset/heavy-toes-attend.md
Outdated
"@latticexyz/cli": patch | ||
--- | ||
|
||
Upgraded the EJS package to 3.1.10, and removed it from `store`, `world`, and `cli`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this might read better in the changelog if we add the "upgrade" changeset to the corresponding packages separately from the "removed" changeset
I try to think of changesets in the context of a single package and how it'll look as if I was reading just that package's changelog (aside from the unique way we roll them up to a single changelog)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this! They are kind of unrelated changes too.
Co-authored-by: Kevin Ingersoll <[email protected]>
No description provided.