Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to ejs 3.1.10 #2786

Merged
merged 7 commits into from
May 2, 2024
Merged

chore: upgrade to ejs 3.1.10 #2786

merged 7 commits into from
May 2, 2024

Conversation

yonadaa
Copy link
Contributor

@yonadaa yonadaa commented May 2, 2024

No description provided.

@yonadaa yonadaa requested review from alvrs and holic as code owners May 2, 2024 12:54
Copy link

changeset-bot bot commented May 2, 2024

🦋 Changeset detected

Latest commit: d4ec425

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 24 packages
Name Type
@latticexyz/world-modules Patch
@latticexyz/store Patch
@latticexyz/cli Patch
@latticexyz/world Patch
@latticexyz/dev-tools Patch
@latticexyz/query Patch
@latticexyz/react Patch
@latticexyz/store-indexer Patch
@latticexyz/store-sync Patch
mock-game-contracts Patch
@latticexyz/abi-ts Patch
@latticexyz/block-logs-stream Patch
@latticexyz/common Patch
@latticexyz/config Patch
create-mud Patch
@latticexyz/faucet Patch
@latticexyz/gas-report Patch
@latticexyz/protocol-parser Patch
@latticexyz/recs Patch
@latticexyz/schema-type Patch
@latticexyz/services Patch
solhint-config-mud Patch
solhint-plugin-mud Patch
@latticexyz/utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

holic
holic previously approved these changes May 2, 2024
@@ -76,7 +76,7 @@
"@types/mocha": "^9.1.1",
"@types/node": "^18.15.11",
"ds-test": "https://github.com/dapphub/ds-test.git#e282159d5170298eb2455a6c05280ab5a73a4ef0",
"ejs": "^3.1.8",
"ejs": "^3.1.10",
Copy link
Member

@holic holic May 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is used in store, world cli, and world-modules? wonder if we can safely remove

"@latticexyz/cli": patch
---

Upgraded the EJS package to 3.1.10, and removed it from `store`, `world`, and `cli`.
Copy link
Member

@holic holic May 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this might read better in the changelog if we add the "upgrade" changeset to the corresponding packages separately from the "removed" changeset

I try to think of changesets in the context of a single package and how it'll look as if I was reading just that package's changelog (aside from the unique way we roll them up to a single changelog)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this! They are kind of unrelated changes too.

@holic holic merged commit 4e4e910 into main May 2, 2024
11 checks passed
@holic holic deleted the yonadaaa/upgrade-ejs branch May 2, 2024 14:08
dhvanipa pushed a commit to tenetxyz/mud that referenced this pull request May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants