fix(cli): do not require PRIVATE_KEY if using KMS

[yonadaa]

No description provided.

[changeset-bot]

🦋 Changeset detected

Latest commit: b8b70d1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 24 packages

Name	Type
@latticexyz/cli	Patch
mock-game-contracts	Patch
@latticexyz/abi-ts	Patch
@latticexyz/block-logs-stream	Patch
@latticexyz/common	Patch
@latticexyz/config	Patch
create-mud	Patch
@latticexyz/dev-tools	Patch
@latticexyz/faucet	Patch
@latticexyz/gas-report	Patch
@latticexyz/protocol-parser	Patch
@latticexyz/query	Patch
@latticexyz/react	Patch
@latticexyz/recs	Patch
@latticexyz/schema-type	Patch
@latticexyz/services	Patch
solhint-config-mud	Patch
solhint-plugin-mud	Patch
@latticexyz/store-indexer	Patch
@latticexyz/store-sync	Patch
@latticexyz/store	Patch
@latticexyz/utils	Patch
@latticexyz/world-modules	Patch
@latticexyz/world	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[holic]

can we move this PK block down under resolvedConfig so its a bit more localized with the KMS stuff?

and could potentially wrap it in a self invoking function like

const account = keyId ? await kmsKeyToAccount({ keyId }) : (() => {
  const privateKey = process.env.PRIVATE_KEY as Hex;
  if (!privateKey) {
    throw new MUDError(
      `Missing PRIVATE_KEY environment variable.
Run 'echo "PRIVATE_KEY=0xac0974bec39a17e36ba4a6b4d238ff944bacb478cbed5efcae784d7bf4f2ff80" > .env'
in your contracts directory to use the default anvil private key.`,
    );
  }
  return privateKeyToAccount(privateKey);
})();

or maybe pull that out into something like envPrivateKeyToAccount()

[yonadaa]

wrapped it all in a self-invoking function! I like that the two environment variables are only used there

[holic]

and one we might be able to ditch in #2760 ?