Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(store): enforce unique table names across types #2736

Merged
merged 14 commits into from
Apr 25, 2024
Merged

fix(store): enforce unique table names across types #2736

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
943d536
feat(store): table ID is unique on namespace and name
yonadaa Apr 25, 2024
9f1b338
fix: set tables and resourceIds as exists
yonadaa Apr 25, 2024
e0f967b
refactor: remove index table
yonadaa Apr 25, 2024
c43d3da
chore: docs
yonadaa Apr 25, 2024
b5168ff
refactor: just check onchain and offchain
yonadaa Apr 25, 2024
b5b6a04
refactor: getResourceName
yonadaa Apr 25, 2024
0d54fb4
chore: changeset
yonadaa Apr 25, 2024
0c1b22b
chore: tweak changeset
yonadaa Apr 25, 2024
0af07a1
Update .changeset/strong-lobsters-shake.md
holic Apr 25, 2024
40ba6ee
chore: bump protocol versions
yonadaa Apr 25, 2024
4d44412
chore: snap
yonadaa Apr 25, 2024
966df87
chore: supported versions
yonadaa Apr 25, 2024
746f0b5
generate docs
holic Apr 25, 2024
7bf0f2f
Merge branch 'main' into yonadaaa/unique-namespace-name
holic Apr 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions docs/pages/store/reference/misc.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1850,6 +1850,26 @@ function getType(ResourceId resourceId) internal pure returns (bytes2);
| -------- | -------- | ------------------------------------- |
| `<none>` | `bytes2` | The extracted 2-byte type identifier. |

#### getNameStore

Get the name from a resource ID.

```solidity
function getNameStore(ResourceId resourceId) internal pure returns (bytes30);
```

**Parameters**

| Name | Type | Description |
| ------------ | ------------ | ---------------- |
| `resourceId` | `ResourceId` | The resource ID. |

**Returns**

| Name | Type | Description |
| -------- | --------- | --------------- |
| `<none>` | `bytes30` | A 30-byte name. |

## ResourceIdLib

[Git Source](https://github.com/latticexyz/mud/blob/main/packages/store/src/ResourceId.sol)
Expand Down
Loading
Loading