Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cli): getWorldContracts #2718

Merged
merged 7 commits into from
Apr 24, 2024
Merged

refactor(cli): getWorldContracts #2718

merged 7 commits into from
Apr 24, 2024

Conversation

yonadaa
Copy link
Contributor

@yonadaa yonadaa commented Apr 24, 2024

In #2662 (contract verification) it is useful to have a list of the names and bytecode for the standard contracts deployed by MUD (InitModule, World etc.)

As pointed out in #2662 (comment) we can split this into a seperate PR and rework the approach too.

Copy link

changeset-bot bot commented Apr 24, 2024

⚠️ No Changeset found

Latest commit: 5e8e312

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@yonadaa yonadaa changed the title refactor(cli): getWorldFactoryContracts refactor(cli): getWorldContracts Apr 24, 2024
@yonadaa yonadaa marked this pull request as ready for review April 24, 2024 13:58
@yonadaa yonadaa requested review from alvrs and holic as code owners April 24, 2024 13:58
Co-authored-by: Kevin Ingersoll <[email protected]>
@yonadaa yonadaa merged commit 378d720 into main Apr 24, 2024
11 of 12 checks passed
@yonadaa yonadaa deleted the yonadaaa/get-world-contracts branch April 24, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants