Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): deploy with kms #2704

Merged
merged 56 commits into from
Apr 25, 2024
Merged

feat(cli): deploy with kms #2704

merged 56 commits into from
Apr 25, 2024

Conversation

yonadaa
Copy link
Contributor

@yonadaa yonadaa commented Apr 22, 2024

Fixes #2594

The AWS configuration and credentials can be set with environment variables: https://docs.aws.amazon.com/cli/latest/userguide/cli-configure-envvars.html

Specifically, KMS requires AWS_ACCESS_KEY_ID, AWS_SECRET_ACCESS_KEY, AWS_REGION and AWS_ENDPOINT_URL.

holic
holic previously approved these changes Apr 23, 2024
Copy link
Member

@holic holic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cleaaannn

Base automatically changed from yonadaaa/deploy-kms to main April 24, 2024 14:32
@yonadaa yonadaa dismissed holic’s stale review April 24, 2024 14:32

The base branch was changed.

Copy link
Member

@holic holic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@yonadaa yonadaa merged commit c74a664 into main Apr 25, 2024
12 checks passed
@yonadaa yonadaa deleted the yonadaaa/kms-deployer branch April 25, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for deploying via KMS to MUD deployer
2 participants