Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(store-sync): await fetchAndStoreLogs #2702

Merged
merged 2 commits into from
Apr 22, 2024
Merged

fix(store-sync): await fetchAndStoreLogs #2702

merged 2 commits into from
Apr 22, 2024

Conversation

alvrs
Copy link
Member

@alvrs alvrs commented Apr 22, 2024

This change was introduced by https://github.com/latticexyz/mud/pull/2665/files but @dhvanipa found a bug with the new approach (we actually want to await the storing of logs, which might get out of order with just map)

Copy link

changeset-bot bot commented Apr 22, 2024

🦋 Changeset detected

Latest commit: 672f663

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 24 packages
Name Type
@latticexyz/store-sync Patch
@latticexyz/dev-tools Patch
@latticexyz/store-indexer Patch
@latticexyz/abi-ts Patch
@latticexyz/block-logs-stream Patch
@latticexyz/cli Patch
@latticexyz/common Patch
@latticexyz/config Patch
create-mud Patch
@latticexyz/faucet Patch
@latticexyz/gas-report Patch
@latticexyz/protocol-parser Patch
@latticexyz/query Patch
@latticexyz/react Patch
@latticexyz/recs Patch
@latticexyz/schema-type Patch
@latticexyz/services Patch
solhint-config-mud Patch
solhint-plugin-mud Patch
@latticexyz/store Patch
@latticexyz/utils Patch
@latticexyz/world-modules Patch
@latticexyz/world Patch
mock-game-contracts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

holic
holic previously approved these changes Apr 22, 2024
@alvrs alvrs marked this pull request as ready for review April 22, 2024 11:27
@alvrs alvrs requested a review from yonadaa as a code owner April 22, 2024 11:27
@holic holic merged commit 16695fe into main Apr 22, 2024
12 checks passed
@holic holic deleted the alvrs/fix-sync branch April 22, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants