Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: skip docker build/release for now #2618

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Conversation

holic
Copy link
Member

@holic holic commented Apr 5, 2024

The workflow is not valid. .github/workflows/snapshot.yml (Line: 65, Col: 3): Error calling workflow 'latticexyz/mud/.github/workflows/docker.yml@a9e8a40'. The nested job 'docker' is requesting 'packages: write', but is only allowed 'packages: read'.

CI is broken, I think since moving to GitHub Enterprise? I'm not really sure how to fix this but wanna unblock npm releases.

Copy link

changeset-bot bot commented Apr 5, 2024

⚠️ No Changeset found

Latest commit: 98c6040

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@holic holic marked this pull request as ready for review April 5, 2024 07:03
@holic holic requested review from alvrs and yonadaa as code owners April 5, 2024 07:03
@holic
Copy link
Member Author

holic commented Apr 5, 2024

running this manually to see what happens: https://github.com/latticexyz/mud/actions/runs/8566312064

@holic
Copy link
Member Author

holic commented Apr 5, 2024

image

hmm I thought this CI job had resolved itself and didn't choke on the / anymore but I guess not

@holic holic merged commit 6c9767c into main Apr 5, 2024
13 of 14 checks passed
@holic holic deleted the holic/skip-docker-release branch April 5, 2024 07:34
@holic
Copy link
Member Author

holic commented Apr 5, 2024

yolo merging, will revert if this doesn't do the trick

@holic
Copy link
Member Author

holic commented Apr 5, 2024

that worked, npm releases are going out again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant