fix(store): return zero for uninitialised static array elements #2613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5663590 The changes in this PR will be included in the next version bump. This PR includes changesets to release 24 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
alvrs
reviewed
Apr 4, 2024
yonadaa
commented
Apr 4, 2024
alvrs
reviewed
Apr 4, 2024
alvrs
reviewed
Apr 4, 2024
alvrs
reviewed
Apr 4, 2024
Co-authored-by: alvarius <[email protected]>
yonadaa
changed the title
holic
reviewed
Apr 4, 2024
.changeset/popular-oranges-end.md
Outdated
| "@latticexyz/cli": patch | ||
| --- | ||
|
|
||
| Fixed the behaviour of static arrays, so that they always return zero for uninitialised values. Previously they would revert with `Store_IndexOutOfBounds` if the index had not been set yet. |
There was a problem hiding this comment.
Should we make a note about this matching native solidity behavior?
There was a problem hiding this comment.
I like that! lemme think
alvrs
reviewed
Apr 4, 2024
alvrs
previously approved these changes
Apr 4, 2024
holic
reviewed
Apr 5, 2024
| // but ahead of the dynamic length, return zero | ||
| typeWrappingData && typeWrappingData.kind === "staticArray" && field.arrayElement | ||
| ? ` | ||
| uint256 _byteLength = ${_store}.getDynamicFieldLength(_tableId, _keyTuple, ${dynamicSchemaIndex}); |
There was a problem hiding this comment.
I would expect this to add gas but not seeing a gas report change. Are we not testing for gas on static-length array fields?
There was a problem hiding this comment.
I wondered that also. It seems like we don't report table libraries for this (or at all?)
holic
reviewed
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the behaviour of static arrays to return default values on "uninitialised" values. If an array index is less than the static length, but greater than the underlying dynamic length, we return zero.