Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(world-modules): explicitly export mud config #2598

Merged
merged 6 commits into from
Apr 4, 2024

Conversation

holic
Copy link
Member

@holic holic commented Apr 3, 2024

I was seeing issues when importing from @latticexyz/world-modules/mud.config and an explicit export seems to fix it.

Copy link

changeset-bot bot commented Apr 3, 2024

🦋 Changeset detected

Latest commit: 05c925a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 24 packages
Name Type
@latticexyz/world-modules Patch
@latticexyz/cli Patch
@latticexyz/abi-ts Patch
@latticexyz/block-logs-stream Patch
@latticexyz/common Patch
@latticexyz/config Patch
create-mud Patch
@latticexyz/dev-tools Patch
@latticexyz/faucet Patch
@latticexyz/gas-report Patch
@latticexyz/protocol-parser Patch
@latticexyz/query Patch
@latticexyz/react Patch
@latticexyz/recs Patch
@latticexyz/schema-type Patch
@latticexyz/services Patch
solhint-config-mud Patch
solhint-plugin-mud Patch
@latticexyz/store-indexer Patch
@latticexyz/store-sync Patch
@latticexyz/store Patch
@latticexyz/utils Patch
@latticexyz/world Patch
mock-game-contracts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@holic holic marked this pull request as ready for review April 3, 2024 06:35
@holic holic requested review from alvrs and yonadaa as code owners April 3, 2024 06:35
yonadaa
yonadaa previously approved these changes Apr 3, 2024
"typesVersions": {
"*": {
"internal/mud.config": [
"./mud.config.ts"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am surprised I needed this, but I guess its because the .ts file is at the same path as the import for world/store packages.

@holic holic merged commit e3c3a11 into main Apr 4, 2024
12 checks passed
@holic holic deleted the holic/world-modules-mud-config branch April 4, 2024 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants