feat(world-modules): add callWithSignature

[yonadaa]

Replace registerDelegationWithSignature with a more generic callWithSignature

[changeset-bot]

⚠️ No Changeset found

Latest commit: 5b10bc5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[holic]

any reason we can't import this from world-modules?

[yonadaa]

I guess I didn't think to try it 🤯

[holic]

I wonder if there's a way we can express this as a struct in solidity then import the ABI here instead of manually defining in both spots

[yonadaa]

I agree this would be great, I'm surprised I haven't seen it anyone do it. The problem is we need to derive the EIP712 typehash:

bytes32 constant CALL_TYPEHASH = keccak256("Call(address delegator,bytes32 systemId,bytes callData,uint256 nonce)");

We could define a struct:

struct Call {
  address delegator,
  bytes32 systemId,
  bytes memory callData,
  uint256 nonce
}

But we'd have to somehow get the names and datatypes of each member as strings, then concat them. It's like we need .selector for structs! (then ensure it's included in the ABI)

Maybe we could define a function selector instead? 🤔 I'll keep thinking about it

[holic]

do we only need the hash in solidity? if so, I think a struct + hash together makes sense and is much closer to ideal than this being defined in multiple places

I think .selector is only bytes4 and not the full bytes32 so a function definition wouldn't help much, but a very cool idea if it could

[yonadaa]

I see what you mean, see we define it twice, but in the same place? As struct and hash.

How do you include a struct in the ABI though? also we'd need to transform the ABI item into the proper viem type

[holic]

ahh I think I assumed structs would be part of the ABI but they aren't, unless they're used as a function arg but even then it's an ABI for the function args with an internalType named struct Call (not just Call)

close but not quite, but maybe close enough?

struct Call {
  address delegator,
  bytes32 systemId,
  bytes memory callData,
  uint256 nonce
}

interface ITypedData {
  function Call(Call memory typedData) public view;
}

[alvrs]

Wonder if we should call this signer in this context. Delegations are similar but kind of a different concept to this path of calling on behalf of someone else

Suggested change

	address delegator,
	address signer,

[yonadaa]

I agree delegator is confusing in this context. signer is also what OpenZeppelin calls it in the SignatureChecker so i'm good with that