Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cli): remove forge cache workaround #2576

Merged
merged 2 commits into from
Apr 1, 2024

Conversation

holic
Copy link
Member

@holic holic commented Mar 31, 2024

this was fixed upstream! 🎉

Copy link

changeset-bot bot commented Mar 31, 2024

🦋 Changeset detected

Latest commit: a2918bb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 24 packages
Name Type
@latticexyz/cli Patch
@latticexyz/abi-ts Patch
@latticexyz/block-logs-stream Patch
@latticexyz/common Patch
@latticexyz/config Patch
create-mud Patch
@latticexyz/dev-tools Patch
@latticexyz/faucet Patch
@latticexyz/gas-report Patch
@latticexyz/protocol-parser Patch
@latticexyz/query Patch
@latticexyz/react Patch
@latticexyz/recs Patch
@latticexyz/schema-type Patch
@latticexyz/services Patch
solhint-config-mud Patch
solhint-plugin-mud Patch
@latticexyz/store-indexer Patch
@latticexyz/store-sync Patch
@latticexyz/store Patch
@latticexyz/utils Patch
@latticexyz/world-modules Patch
@latticexyz/world Patch
mock-game-contracts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@holic holic marked this pull request as ready for review March 31, 2024 05:01
@holic holic requested review from alvrs and yonadaa as code owners March 31, 2024 05:01
Copy link
Member

@alvrs alvrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you confirm locally that the IWorld Abi is now regenerated when a system contract interface is changed?

@holic
Copy link
Member Author

holic commented Apr 1, 2024

Yep! It does appear to update IWorld.abi.json when I change a system (e.g. adding or removing a function)

@holic holic merged commit 3b845d6 into main Apr 1, 2024
12 checks passed
@holic holic deleted the holic/remove-forge-cache-workaround branch April 1, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants