Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(store,world): minor config validation fixes #2517

Merged
merged 10 commits into from
Mar 21, 2024
Merged

Conversation

alvrs
Copy link
Member

@alvrs alvrs commented Mar 21, 2024

Minor fixes to config input validations:

  • systems.openAccess incorrectly expected true as the only valid input. It now allows boolean.
  • The config complained if parts of it were defined as const outside the config input. This is now possible.
  • Shorthand inputs are now enabled.

@alvrs alvrs requested review from holic and yonadaa as code owners March 21, 2024 20:05
Copy link

changeset-bot bot commented Mar 21, 2024

🦋 Changeset detected

Latest commit: 92c170c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 24 packages
Name Type
@latticexyz/store Patch
@latticexyz/world Patch
@latticexyz/cli Patch
@latticexyz/dev-tools Patch
@latticexyz/query Patch
@latticexyz/react Patch
@latticexyz/store-indexer Patch
@latticexyz/store-sync Patch
@latticexyz/world-modules Patch
@latticexyz/abi-ts Patch
@latticexyz/block-logs-stream Patch
@latticexyz/common Patch
@latticexyz/config Patch
create-mud Patch
@latticexyz/faucet Patch
@latticexyz/gas-report Patch
@latticexyz/protocol-parser Patch
@latticexyz/recs Patch
@latticexyz/schema-type Patch
@latticexyz/services Patch
solhint-config-mud Patch
solhint-plugin-mud Patch
@latticexyz/utils Patch
mock-game-contracts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

.changeset/dry-toes-lay.md Outdated Show resolved Hide resolved
.changeset/dry-toes-lay.md Outdated Show resolved Hide resolved
} as const;

attest(defineStore({ enums }).enums).equals(enums);
});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @0xhank

holic
holic previously approved these changes Mar 21, 2024
@alvrs alvrs merged commit 4a6b459 into main Mar 21, 2024
11 checks passed
@alvrs alvrs deleted the alvrs/config-fixes branch March 21, 2024 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants