Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(store, world): add table deploy config, add v2 to v1 compat config #2482

Merged
merged 9 commits into from
Mar 20, 2024
Merged

feat(store, world): add table deploy config, add v2 to v1 compat config #2482

merged 9 commits into from
Mar 20, 2024

Conversation

alvrs
Copy link
Member

@alvrs alvrs commented Mar 20, 2024 •
edited
Loading

  • rename deployment to deploy
  • add deploy config option to table options
  • add v2 key to output of v1 compat layer

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 20, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 6cacf4f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@alvrs alvrs changed the title feat(store, world): include default tables in config feat(store, world): add table deploy config, add v2 to v1 compat config Mar 20, 2024
@alvrs alvrs marked this pull request as ready for review March 20, 2024 16:44
@alvrs alvrs requested review from holic and yonadaa as code owners March 20, 2024 16:44
holic
holic previously approved these changes Mar 20, 2024
View reviewed changes
Copy link
Member

@holic holic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only question I have is disable vs disabled 🤔

@holic holic merged commit 20ffc95 into main Mar 20, 2024
11 checks passed
@holic holic deleted the alvrs/default-tables branch March 20, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holic holic holic approved these changes

@yonadaa yonadaa Awaiting requested review from yonadaa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alvrs @holic