Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(store, world): throw if required keys are not provided, more validations #2481

Merged
merged 7 commits into from
Mar 20, 2024
Merged

feat(store, world): throw if required keys are not provided, more validations #2481

merged 7 commits into from
Mar 20, 2024

Conversation

alvrs
Copy link
Member

@alvrs alvrs commented Mar 20, 2024 •
edited
Loading

Add more type errors for missing required keys or invalid inputs

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 20, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 546f73c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@alvrs alvrs changed the title feat(store, world): make some keys required feat(store, world): throw if required keys are not provided, more validations Mar 20, 2024
@alvrs alvrs marked this pull request as ready for review March 20, 2024 15:25
holic
holic reviewed Mar 20, 2024
View reviewed changes
packages/store/ts/config/v2/input.ts
@@ -26,7 +26,7 @@ export type TablesInput = {

export type StoreInput = {
readonly namespace?: string;
readonly tables: TablesInput;
readonly tables?: TablesInput;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it necessary for this to be optional?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was an oversight, you don't have to provide tables in your config

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when would you want to specify a config without tables?

@alvrs alvrs requested a review from yonadaa as a code owner March 20, 2024 15:28
@alvrs alvrs merged commit cc4f424 into main Mar 20, 2024
12 checks passed
@alvrs alvrs deleted the alvrs/required-keys-2 branch March 20, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holic holic holic approved these changes

@yonadaa yonadaa Awaiting requested review from yonadaa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alvrs @holic