-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(store): add StoreWrite and Store abstract contracts #2411
Conversation
🦋 Changeset detectedLatest commit: a56a7d2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
docs need to be regenerated (and prob an issue of #2351 again) |
I am now wondering if my protocol version tests are incorrect and should use |
It wasn't actually, it was because the docs tried to read
Interesting, so the tests should read different interfaces? As opposed to what? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small docs changes but otherwise good to go
Co-authored-by: Kevin Ingersoll <[email protected]>
Co-authored-by: Kevin Ingersoll <[email protected]>
Co-authored-by: Kevin Ingersoll <[email protected]>
Fixes #2369
Added an
abstract
StoreKernel
contract, which includes all Store interfaces except for registration, and implements write methods,protocolVersion
and initializesStoreCore
.Store
extendsStoreKernel
with theIStoreRegistration
interface.StoreData
is removed as a separate interface/contract.World
now extendsStoreKernel
(since the registration methods are added via theInitModule
).