chore: remove some unused files #2398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 80c6f3f The changes in this PR will be included in the next version bump. This PR includes changesets to release 31 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
yonadaa
force-pushed
the
yonadaaa/remove-unused-files
branch
from
32eb946 to
a1f5492
Compare
holic
previously approved these changes
Mar 8, 2024
holic
reviewed
Mar 9, 2024
| @@ -1,3 +0,0 @@ | |||
| export function identity<T>(value: T): T { | |||
| return value; | |||
| } | |||
There was a problem hiding this comment.
can we leave this one? I assume this didn't cause TS issues
holic
reviewed
Mar 9, 2024
| export * from "./groupBy"; | ||
| export * from "./identity"; |
There was a problem hiding this comment.
prob need a changeset for removing exports
holic
reviewed
Mar 11, 2024
| "@latticexyz/react": patch | ||
| --- | ||
|
|
||
| Removed some unused files, namely `curry` in `@latticexyz/common` and `useDeprecatedComputedValue` from `@latticexyz/react`. |
There was a problem hiding this comment.
for future reference, you can create a changeset for each package with the package-specific changes so that we don't need the irrelevant change in another package's changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These files are not referenced elsewhere in the codebase and cause type errors (surfaced in #2398), so we can remove them and simplify the codebase a tiny bit.