Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(store-sync): track changed records together in zustand #2387

Merged
merged 2 commits into from
Mar 7, 2024

Conversation

holic
Copy link
Member

@holic holic commented Mar 7, 2024

when playing with this in #2355, I noticed a possible edge case where tracking these updated IDs separately meant that an update -> delete or delete -> update for the same record in the same block could give the wrong results in the end (out of sync from chain state)

Copy link

changeset-bot bot commented Mar 7, 2024

🦋 Changeset detected

Latest commit: 536936f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 31 packages
Name Type
@latticexyz/store-sync Patch
@latticexyz/dev-tools Patch
@latticexyz/store-indexer Patch
@latticexyz/abi-ts Patch
@latticexyz/block-logs-stream Patch
@latticexyz/cli Patch
@latticexyz/common Patch
@latticexyz/config Patch
create-mud Patch
@latticexyz/ecs-browser Patch
@latticexyz/faucet Patch
@latticexyz/gas-report Patch
@latticexyz/network Patch
@latticexyz/noise Patch
@latticexyz/phaserx Patch
@latticexyz/protocol-parser Patch
@latticexyz/react Patch
@latticexyz/recs Patch
@latticexyz/schema-type Patch
@latticexyz/services Patch
@latticexyz/solecs Patch
solhint-config-mud Patch
solhint-plugin-mud Patch
@latticexyz/std-client Patch
@latticexyz/std-contracts Patch
@latticexyz/store-cache Patch
@latticexyz/store Patch
@latticexyz/utils Patch
@latticexyz/world-modules Patch
@latticexyz/world Patch
mock-game-contracts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@holic holic changed the title fix(store-sync): always track touched IDs in zustand fix(store-sync): track changed records together in zustand Mar 7, 2024
@holic holic marked this pull request as ready for review March 7, 2024 13:45
@holic holic requested review from alvrs and yonadaa as code owners March 7, 2024 13:45
yonadaa
yonadaa previously approved these changes Mar 7, 2024
Copy link
Contributor

@yonadaa yonadaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changeset?

@holic holic merged commit 3f5d33a into main Mar 7, 2024
10 of 11 checks passed
@holic holic deleted the holic/zustand-touched-ids branch March 7, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants