-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(store-sync): adjust DB schema/table names for consistency #2379
Conversation
🦋 Changeset detectedLatest commit: 26c845a The changes in this PR will be included in the next version bump. This PR includes changesets to release 31 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ced444e
to
fb0fab1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reasoning makes sense! I worry this might be less useable though, because a useful "division" (ie. pg namespaces) we can have are into MUD namespaces.
For example, with the Sky Strife analytics indexer, the indexer already has a specific world address, and it's useful to SEARCH_PATH
a specific namespace to save rewriting long table names: https://github.com/latticexyz/skystrife-public/blob/main/sql-queries/WalletMatchesJoined.sql#L1-L2
basically does this best take advantage of Postgres namespaces?
since sky strife uses root namespace, you won't need to do anything differently here except remove the the idea is that selecting from SQL tables will look/feel the same as fetching data from tables in client |
part of #2173
{address}__{namespace}.{tableName}
to{address}.{namespace}__{tableName}