test(e2e): fix memory corruption test

[yonadaa]

Fixes the test created in #1880

I'm not 100% sure what the intention of this test is, when I run it the memory it the elements of result are the same as data (ie. not corrupted). Maybe this test added before the fix, to prove it was broken?

[changeset-bot]

⚠️ No Changeset found

Latest commit: 5f5fc7c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[dk1a]

Memory corruption would occur when the dynamic length is smaller than the static length, so this test doesn't even make sense
I don't remember why I made it this way, but it looks like a mistake
Rather than fixing asserts, remaking the test completely would probably be better

[dk1a]

On the other hand 2 tests are also fine, but they would test for different kinds of memory corruption
The current one seems much less important

[yonadaa]

Thanks for the clarification @dk1a! I added tests for different dynamic array lengths, but maybe we can test memory corruption more thoroughly

[dk1a]

but maybe we can test memory corruption more thoroughly

You can add memoryAfterResult for the others, especially shorterDynamic - you'd want to allocate something right after data, and make sure it's not corrupted (probably would require manual assembly allocation, you can't rely on solidity to not reorder allocations)

[holic]

ooc any reason this lives in e2e and not in store? seems critical enough to live in store

[dk1a]

ooc any reason this lives in e2e and not in store?

to avoid a test-only table in store