refactor(store): hellostore in IStoreEvents #2357
Conversation
🦋 Changeset detectedLatest commit: ad88233 The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
packages/store/src/IStoreEvents.sol
Outdated
| * @notice Emitted when the store is initialized. | ||
| * @param storeVersion The version of the Store contract. | ||
| */ | ||
| event HelloStore(bytes32 indexed storeVersion); |
There was a problem hiding this comment.
nit: would put this at the top since it's the first event you'll see
There was a problem hiding this comment.
i was also wondering that haha
yonadaa
changed the title
There was a problem hiding this comment.
don't forget a changeset!
should we make it so StoreData.sol uses emit IStoreEvents.HelloStore rather than emit HelloStore for consistency?
and maybe IStore inherits IStoreEvents directly (rather than transitively) so that we get an error in StoreData.sol if we don't use the interface reference for emitting the event?
nevermind, don't think this is possible with how we've set up store abstractions
sure, seems more flexible to me! |
No description provided.