Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: viem custom client within external wallet example #2294

Conversation

tash-2s
Copy link
Contributor

@tash-2s tash-2s commented Feb 23, 2024

This pull request is not meant to be merged.

In this PR, I'm experimenting with the viem custom client implementation within the external wallet example project.


The target branch is exactly the same as #2268. This change will be incorporated into that PR later, but for now, I'm using this PR to easily review the diff.

(Going forward, I'll create branches directly from latticexyz/mud instead of using my fork for PRs so that I can create a PR targeting my other PR within this repository.)

Copy link

changeset-bot bot commented Feb 23, 2024

⚠️ No Changeset found

Latest commit: 59960ad

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@tash-2s tash-2s mentioned this pull request Feb 23, 2024
@tash-2s tash-2s force-pushed the tash-2s/viem-custom-client branch from e24f1d1 to 09586fd Compare February 23, 2024 17:20
```
 WARN  Issues with peer dependencies found
packages/client-react-external-wallet
└─┬ wagmi 2.5.7
  └─┬ @wagmi/connectors 4.1.14
    └─┬ @metamask/sdk 0.14.3
      ├─┬ @metamask/sdk-communication-layer 0.14.3
      │ └─┬ socket.io-client 4.7.4
      │   └─┬ engine.io-client 6.5.3
      │     └─┬ ws 8.11.0
      │       └── ✕ unmet peer utf-8-validate@^5.0.2: found 6.0.3 in @metamask/sdk-communication-layer
      ├─┬ @metamask/sdk-install-modal-web 0.14.1
      │ └─┬ react-i18next 13.5.0
      │   └── ✕ unmet peer i18next@">= 23.2.3": found 22.5.1 in @metamask/sdk-install-modal-web
      └─┬ react-i18next 13.5.0
        └── ✕ unmet peer i18next@">= 23.2.3": found 22.5.1 in @metamask/sdk
```
@tash-2s
Copy link
Contributor Author

tash-2s commented Feb 23, 2024

Closing in favor of #2307

@tash-2s tash-2s closed this Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant