feat(store-sync): bool array column types for decoded indexer #2283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b280ce6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
holic
reviewed
Feb 20, 2024
| @@ -234,7 +243,7 @@ export function buildColumn(name: string, schemaAbiType: SchemaAbiType) { | |||
| case "bytes31[]": | |||
| case "bytes32[]": | |||
| case "bool[]": | |||
| return asJson(name); | |||
| return asBoolArray(name); | |||
There was a problem hiding this comment.
erm, I think this applying the column type to all the above array types, not just the bool type
There was a problem hiding this comment.
since this is a column change, should bump the postgres schema/sync version
There was a problem hiding this comment.
Oh thanks - been looking at these column types for too long 😵💫
holic
reviewed
Feb 20, 2024
Co-authored-by: Kevin Ingersoll <[email protected]>
holic
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulled out from #2251