fix(gas-report): update filename matcher #2277
Conversation
🦋 Changeset detectedLatest commit: c1d690b The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
packages/gas-report/ts/index.ts
Outdated
| @@ -130,7 +130,7 @@ async function runGasReport(options: Options): Promise<GasReport> { | |||
| const lines = logs.split("\n").map(stripAnsi); | |||
| const gasReportPattern = /^\s*GAS REPORT: (\d+) (.*)$/; | |||
| const testFunctionPattern = /^\[(?:PASS|FAIL).*\] (\w+)\(\)/; | |||
| const testFilePattern = /^Running \d+ tests? for (.*):(.*)$/; | |||
| const testFilePattern = /^Ran \d+ tests? for (.*):(.*)$/; | |||
There was a problem hiding this comment.
nice catch! thoughts on testing for both instead of just one? so we can support older foundry versions for a little while? maybe with a comment explaining
There was a problem hiding this comment.
Sure! I have amended the commit.
pwrstudio
force-pushed
the
gas-report-test-filename
branch
from
8ba9947 to
5a2f702
Compare
holic
changed the title
|
can you enable us to edit the branch/PR? I'd like to add a changeset so we can merge this |
|
Hmm seems to be a bit problematic because my branch is under a org account: https://github.com/orgs/community/discussions/5634 |
|
that's okay! another option is to add the changeset yourself from the root of the mud repo or click the link in #2277 (comment) |
Co-authored-by: Kevin Ingersoll <[email protected]>
Co-authored-by: Kevin Ingersoll <[email protected]>
|
thank you! |
Fixes #2276