feat(cli): hardcode table ID with codegen #2229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 74c08c3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
holic
changed the title
holic
commented
Feb 1, 2024
| ResourceId constant _tableId = ResourceId.wrap( | ||
| bytes32(abi.encodePacked(RESOURCE_TABLE, bytes14("store"), bytes16("StoreHooks"))) | ||
| ); | ||
| ResourceId constant _tableId = ResourceId.wrap(0x746273746f726500000000000000000053746f7265486f6f6b73000000000000); |
There was a problem hiding this comment.
I don't mind this being a bit obscure since it's codegen, but if we feel like this magic constant should be clarified to end-users, we could add some codegen'ed comments above this explaining what's in this hex value (so we still get clarity along with gas benefits)
alvrs
reviewed
Feb 2, 2024
Comment on lines
23
to
22
| ResourceId constant _tableId = ResourceId.wrap( | ||
| bytes32(abi.encodePacked(RESOURCE_TABLE, bytes14(""), bytes16("Multi"))) | ||
| ); | ||
| ResourceId constant _tableId = ResourceId.wrap(0x746200000000000000000000000000004d756c74690000000000000000000000); |
There was a problem hiding this comment.
can we add a comment above these that explains this hex value?
Something like
// Hex below is the result of `WorldResourceIdLib.encode({ namespace: "", name: "Multi", typeId: RESOURCE_TABLE });`
holic
force-pushed
the
holic/hardcode-table-id
branch
from
5b707f7 to
74c08c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doing this as a precursor to #2166 and found that this had a gas improvement in the hot path!