-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(store): rename StoreCore.registerCoreTables to registerInternalTables #2225
Conversation
🦋 Changeset detectedLatest commit: e58b76f The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
50a7ace
to
dbf9a37
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this a lot more, "Core Module" made it seem like some overly important piece
_registerSystem(balanceTransferSystem, BALANCE_TRANSFER_SYSTEM_ID); | ||
_registerSystem(batchCallSystem, BATCH_CALL_SYSTEM_ID); | ||
_registerSystem(coreRegistrationSystem, CORE_REGISTRATION_SYSTEM_ID); | ||
function _registerInternalSystems() internal { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
feels a little bit off to call these "internal systems" - with that name I'd think of internal functions, ie something that's not externally accessible, but these systems become part of the "core" API 🙈
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since we're in the CoreModule
(soon InitModule
), maybe we can just name these _registerTables
, _registerSystems
, and _registerSystem
because that's what installing the module does? _registerFunctionSelectors
is already named as such.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
went ahead and did this in e58b76f
to clarify and clear the "core" term for other uses