fix(world-modules): SystemSwitch properly calls systems from root

[yonadaa]

Fixes #2089

Added a test case that fails without this code change

[changeset-bot]

🦋 Changeset detected

Latest commit: 1bc3139

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages

Name	Type
@latticexyz/world-modules	Major
@latticexyz/cli	Major
@latticexyz/abi-ts	Major
@latticexyz/block-logs-stream	Major
@latticexyz/common	Major
@latticexyz/config	Major
create-mud	Major
@latticexyz/dev-tools	Major
@latticexyz/ecs-browser	Major
@latticexyz/faucet	Major
@latticexyz/gas-report	Major
@latticexyz/network	Major
@latticexyz/noise	Major
@latticexyz/phaserx	Major
@latticexyz/protocol-parser	Major
@latticexyz/react	Major
@latticexyz/recs	Major
@latticexyz/schema-type	Major
@latticexyz/services	Major
@latticexyz/solecs	Major
solhint-config-mud	Major
solhint-plugin-mud	Major
@latticexyz/std-client	Major
@latticexyz/std-contracts	Major
@latticexyz/store-cache	Major
@latticexyz/store-indexer	Major
@latticexyz/store-sync	Major
@latticexyz/store	Major
@latticexyz/utils	Major
@latticexyz/world	Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[alvrs]

looking at this I wonder if we should just use the SystemCall.call library here

  function call(ResourceId systemId, bytes memory callData) internal returns (bytes memory returnData) {
    address worldAddress = WorldContextConsumerLib._world();

    // If we're in the World context, call via the internal library
    if (address(this) == worldAddress) {
      return SystemCall.call(systemId, callData);
    }

    // Otherwise, call the system via world.call
    returnData = IWorldKernel(worldAddress).call(systemId, callData);
  }

[yonadaa]

I like this! It adds a small amount of gas for the publicAccess and value checks but it's great to reuse the code.

[holic]

(not blocking this PR) should we change all the other places to use the same lib?

[yonadaa]

Are there other places that do this? Searching for delegatecallWithContext or == ROOT_NAMESPACE doesn't bring up much for me

[yonadaa]

I wonder if this line could cause an error because it updates the balances expecting a root

if (value > 0) {

[yonadaa]

We should merge #2216 into this