Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(store): push to StoreHooks with StoreCore method #2201

Merged
merged 2 commits into from
Jan 30, 2024

Conversation

yonadaa
Copy link
Contributor

@yonadaa yonadaa commented Jan 29, 2024

this function is called in StoreCore so we can avoid using StoreSwitch to write to the table.

@yonadaa yonadaa requested review from alvrs and holic as code owners January 29, 2024 10:55
Copy link

changeset-bot bot commented Jan 29, 2024

🦋 Changeset detected

Latest commit: 4be85d3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
@latticexyz/store Patch
@latticexyz/cli Patch
@latticexyz/dev-tools Patch
@latticexyz/react Patch
@latticexyz/store-indexer Patch
@latticexyz/store-sync Patch
@latticexyz/world-modules Patch
@latticexyz/world Patch
@latticexyz/abi-ts Patch
@latticexyz/block-logs-stream Patch
@latticexyz/common Patch
@latticexyz/config Patch
create-mud Patch
@latticexyz/ecs-browser Patch
@latticexyz/faucet Patch
@latticexyz/gas-report Patch
@latticexyz/network Patch
@latticexyz/noise Patch
@latticexyz/phaserx Patch
@latticexyz/protocol-parser Patch
@latticexyz/recs Patch
@latticexyz/schema-type Patch
@latticexyz/services Patch
@latticexyz/solecs Patch
solhint-config-mud Patch
solhint-plugin-mud Patch
@latticexyz/std-client Patch
@latticexyz/std-contracts Patch
@latticexyz/store-cache Patch
@latticexyz/utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@holic holic changed the title perf(store): push to StoreHooks with StoreCore method refactor(store): push to StoreHooks with StoreCore method Jan 30, 2024
@holic
Copy link
Member

holic commented Jan 30, 2024

unclear if this needs a changeset but if we're following "it changed the bytecode", then probably

@yonadaa
Copy link
Contributor Author

yonadaa commented Jan 30, 2024

unclear if this needs a changeset but if we're following "it changed the bytecode", then probably

it has one!

@yonadaa yonadaa merged commit 55a05fd into main Jan 30, 2024
12 checks passed
@yonadaa yonadaa deleted the yonadaaa/store-hooks-push branch January 30, 2024 13:53
@holic
Copy link
Member

holic commented Jan 30, 2024

it has one!

oops 🙈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants