Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(world,world-modules): rename module args to encodedArgs #2199

Merged
merged 6 commits into from
Jan 29, 2024

Conversation

yonadaa
Copy link
Contributor

@yonadaa yonadaa commented Jan 26, 2024

Fixes #1757

This name better reflects that the bytes argument is encoded module arguments, not the actual typed arguments.

@yonadaa yonadaa requested review from alvrs and holic as code owners January 26, 2024 15:45
Copy link

changeset-bot bot commented Jan 26, 2024

🦋 Changeset detected

Latest commit: 3c1803f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
@latticexyz/world-modules Patch
@latticexyz/world Patch
@latticexyz/cli Patch
@latticexyz/dev-tools Patch
@latticexyz/store-sync Patch
@latticexyz/store-indexer Patch
@latticexyz/abi-ts Patch
@latticexyz/block-logs-stream Patch
@latticexyz/common Patch
@latticexyz/config Patch
create-mud Patch
@latticexyz/ecs-browser Patch
@latticexyz/faucet Patch
@latticexyz/gas-report Patch
@latticexyz/network Patch
@latticexyz/noise Patch
@latticexyz/phaserx Patch
@latticexyz/protocol-parser Patch
@latticexyz/react Patch
@latticexyz/recs Patch
@latticexyz/schema-type Patch
@latticexyz/services Patch
@latticexyz/solecs Patch
solhint-config-mud Patch
solhint-plugin-mud Patch
@latticexyz/std-client Patch
@latticexyz/std-contracts Patch
@latticexyz/store-cache Patch
@latticexyz/store Patch
@latticexyz/utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

holic
holic previously approved these changes Jan 26, 2024
Copy link
Member

@holic holic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need a changeset but otherwise 👍

@yonadaa
Copy link
Contributor Author

yonadaa commented Jan 26, 2024

need a changeset but otherwise 👍

Wasn't sure on this one because it was just renaming, will do!

@yonadaa yonadaa merged commit e2d089c into main Jan 29, 2024
11 checks passed
@yonadaa yonadaa deleted the yonadaaa/module-encoded-args branch January 29, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

modules: rename args to encodedArgs
2 participants