fix(common): include only errors defined in the contract

[dk1a]

pulled out of #2171

[changeset-bot]

🦋 Changeset detected

Latest commit: 2aca339

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages

Name	Type
@latticexyz/common	Patch
@latticexyz/block-logs-stream	Patch
@latticexyz/cli	Patch
@latticexyz/config	Patch
@latticexyz/dev-tools	Patch
@latticexyz/faucet	Patch
@latticexyz/protocol-parser	Patch
@latticexyz/store-indexer	Patch
@latticexyz/store-sync	Patch
@latticexyz/store	Patch
@latticexyz/world-modules	Patch
@latticexyz/world	Patch
@latticexyz/react	Patch
@latticexyz/abi-ts	Patch
create-mud	Patch
@latticexyz/ecs-browser	Patch
@latticexyz/gas-report	Patch
@latticexyz/network	Patch
@latticexyz/noise	Patch
@latticexyz/phaserx	Patch
@latticexyz/recs	Patch
@latticexyz/schema-type	Patch
@latticexyz/services	Patch
@latticexyz/solecs	Patch
solhint-config-mud	Patch
solhint-plugin-mud	Patch
@latticexyz/std-client	Patch
@latticexyz/std-contracts	Patch
@latticexyz/store-cache	Patch
@latticexyz/utils	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[holic]

Is there some way to show the outcome of this? In a test or in some example codegen interface?

[dk1a]

Is there some way to show the outcome of this? In a test or in some example codegen interface?

Yeah, we never ran into the issue but I can make an example, test would be trickier (btw do we have tests that compare solidity file contents to expected output?)

[holic]

btw do we have tests that compare solidity file contents to expected output?

not really but a snapshot test would be fine for this I think (grep for toMatchInlineSnapshot)! I am fine with either that or an example that shows output

[dk1a]

Added a simple example (it incorrectly generates the error in main branch)