Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): fix namespaced function signatures #2187

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

holic
Copy link
Member

@holic holic commented Jan 24, 2024

@alvrs pointed this out and I thought we were only relying on the onchain registration for this but apparently not!

missed this in #2160

Copy link

changeset-bot bot commented Jan 24, 2024

⚠️ No Changeset found

Latest commit: 335bf90

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@holic holic requested a review from yonadaa January 24, 2024 16:04
@holic holic marked this pull request as ready for review January 24, 2024 17:04
@holic holic requested a review from alvrs as a code owner January 24, 2024 17:04
Copy link
Contributor

@yonadaa yonadaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I would suggest a helper function but we don't seem to do this anywhere else in TS

@holic
Copy link
Member Author

holic commented Jan 24, 2024

I would suggest a helper function but we don't seem to do this anywhere else in TS

if only we could call solidity from TS

@holic holic merged commit 01cc319 into main Jan 24, 2024
12 checks passed
@holic holic deleted the holic/fix-deployed-world-function-signatures branch January 24, 2024 17:41
holic added a commit that referenced this pull request Jan 24, 2024
@holic holic mentioned this pull request Jan 24, 2024
holic added a commit that referenced this pull request Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants