fix(world): prevent namespace from ending with underscore [M-05]

[alvrs]

follows #2169

[changeset-bot]

🦋 Changeset detected

Latest commit: 6881655

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages

Name	Type
@latticexyz/world	Patch
@latticexyz/cli	Patch
@latticexyz/dev-tools	Patch
@latticexyz/store-sync	Patch
@latticexyz/world-modules	Patch
@latticexyz/store-indexer	Patch
@latticexyz/abi-ts	Patch
@latticexyz/block-logs-stream	Patch
@latticexyz/common	Patch
@latticexyz/config	Patch
create-mud	Patch
@latticexyz/ecs-browser	Patch
@latticexyz/faucet	Patch
@latticexyz/gas-report	Patch
@latticexyz/network	Patch
@latticexyz/noise	Patch
@latticexyz/phaserx	Patch
@latticexyz/protocol-parser	Patch
@latticexyz/react	Patch
@latticexyz/recs	Patch
@latticexyz/schema-type	Patch
@latticexyz/services	Patch
@latticexyz/solecs	Patch
solhint-config-mud	Patch
solhint-plugin-mud	Patch
@latticexyz/std-client	Patch
@latticexyz/std-contracts	Patch
@latticexyz/store-cache	Patch
@latticexyz/store	Patch
@latticexyz/utils	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[holic]

I know I suggested otherwise before, but given the gas report, I wonder if we should split validateNamespace from requireNamespace where

• requireNamespace checks if a resource ID is a namespace type and has an empty name
• validateNamespace checks if the namespace does not have invalid chars

We only need to requireNamespace+validateNamespace on registration, the rest of the functions can just use requireNamespace and save gas

(I don't love the naming of these, maybe validateNamespace renames to requireValidNamespace to more closely match requireNamespace and the intent of each?)

[yonadaa]

requireNamespace and requireValidNamespace have the same notice comment, maybe they could be more specific?

[holic]

whoops, that was a copy pasta issue on my part

[holic]

wait no, they're different

@notice Checks if a given `resourceId` is a namespace.

@notice Checks if a given `resourceId` is a valid namespace.

and the @dev section describes the difference in more detail

[alvrs]

✅ approved