Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: change namespaced function signatures #2167

Merged
merged 1 commit into from
Jan 22, 2024
Merged

docs: change namespaced function signatures #2167

merged 1 commit into from
Jan 22, 2024

Conversation

qbzzt
Copy link
Contributor

@qbzzt qbzzt commented Jan 19, 2024

The old format is namespace_system_function.
The new format is namespace__function.

This should be merged at the same time as #2160, which implements the change.

@qbzzt
docs(*): deal with change in function selector names
eaa027c 
The old format is `namespace_system_function`.
The new format is `namespace__function`.

This should be merged at the same time as #2160, which implements the change.
@qbzzt qbzzt requested review from alvrs and holic as code owners January 19, 2024 15:24
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 19, 2024

⚠️ No Changeset found

Latest commit: eaa027c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@holic holic changed the title docs(*): deal with change in function selector names docs: deal with change in function selector names Jan 19, 2024
@holic holic changed the title docs: deal with change in function selector names docs: change namespaced function signatures Jan 19, 2024
@alvrs alvrs merged commit 0cc3d71 into main Jan 22, 2024
13 checks passed
@alvrs alvrs deleted the 240119-selector-change branch January 22, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvrs alvrs alvrs approved these changes

@holic holic Awaiting requested review from holic holic is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qbzzt @alvrs