Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(world-modules): simplify getUniqueEntity call #2161

Merged
merged 2 commits into from
Jan 19, 2024

Conversation

holic
Copy link
Member

@holic holic commented Jan 18, 2024

Spotted this while working on #2160

Using world.call means we don't need to maintain this manual system interface and it's cheaper on gas.

Copy link

changeset-bot bot commented Jan 18, 2024

🦋 Changeset detected

Latest commit: ce8a79b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
@latticexyz/world-modules Patch
@latticexyz/cli Patch
@latticexyz/abi-ts Patch
@latticexyz/block-logs-stream Patch
@latticexyz/common Patch
@latticexyz/config Patch
create-mud Patch
@latticexyz/dev-tools Patch
@latticexyz/ecs-browser Patch
@latticexyz/faucet Patch
@latticexyz/gas-report Patch
@latticexyz/network Patch
@latticexyz/noise Patch
@latticexyz/phaserx Patch
@latticexyz/protocol-parser Patch
@latticexyz/react Patch
@latticexyz/recs Patch
@latticexyz/schema-type Patch
@latticexyz/services Patch
@latticexyz/solecs Patch
solhint-config-mud Patch
solhint-plugin-mud Patch
@latticexyz/std-client Patch
@latticexyz/std-contracts Patch
@latticexyz/store-cache Patch
@latticexyz/store-indexer Patch
@latticexyz/store-sync Patch
@latticexyz/store Patch
@latticexyz/utils Patch
@latticexyz/world Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@holic holic marked this pull request as ready for review January 18, 2024 18:15
@holic holic requested a review from alvrs as a code owner January 18, 2024 18:15
@holic holic requested a review from yonadaa January 18, 2024 18:15
yonadaa
yonadaa previously approved these changes Jan 19, 2024
Copy link
Contributor

@yonadaa yonadaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat. Using that previous function name was super awkward.

Makes you wonder if there are other places we can do this

@holic holic changed the title feat(world-modules): simplify getUniqueEntity call refactor(world-modules): simplify getUniqueEntity call Jan 19, 2024
@holic holic merged commit eaa766e into main Jan 19, 2024
10 of 11 checks passed
@holic holic deleted the holic/simplify-unique-entity-call branch January 19, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants