fix(world): check the core module name is correct on initialisation [L-05] #2099
Conversation
|
| @@ -75,6 +75,11 @@ contract World is StoreData, IWorldKernel { | |||
| revert World_AlreadyInitialized(); | |||
| } | |||
|
|
|||
| // Require the module name to be core | |||
| if (coreModule.getName() != CORE_MODULE_NAME) { | |||
| revert("Module is not the core module"); | |||
There was a problem hiding this comment.
Do we want a custom error for this?
There was a problem hiding this comment.
thinking more about the original issue/report, I wonder if this check is actually useful
If the implementation of coreModule is malicious, couldn't it easily sidestep this check by returning different values from getName() based on the caller?
curious if @alvrs has opinions here
|
closing in favour of #2168 |
No description provided.