-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(world): prevent misconfigured delegations, allow unregistering [L-04] #2096
Conversation
🦋 Changeset detectedLatest commit: 4b2f271 The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
packages/world/src/modules/core/implementations/WorldRegistrationSystem.sol
Outdated
Show resolved
Hide resolved
This PR is failing integration tests because |
packages/world/src/modules/core/implementations/WorldRegistrationSystem.sol
Show resolved
Hide resolved
Can we add a test while we're here, just to make sure we can unregister a delegation via the world? |
Added a test that you can unregister a delegation, then the call fails |
Currently, we allow clearing delegations by passing empty calldata. However this could cause invalid delegations, so this PR performs full validation regardless of whether
initCallData
is empty.Delegations can now be explicitly unregistered by calling
unregisterDelegation
.