refactor(store,world): rename ambiguous elements [N-03] #2091
Conversation
🦋 Changeset detectedLatest commit: c37c553 The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
packages/store/src/Hook.sol
Outdated
| @@ -30,15 +30,15 @@ library HookLib { | |||
| * @notice Filter a hook from the hook list by its address. | |||
| * @dev This function writes the updated hook list to the table in place. | |||
| * @param hookTableId The resource ID of the hook table. | |||
| * @param tableWithHooks The resource ID of the table with hooks to filter. | |||
| * @param elementWithHooks The resource ID of the table with hooks to filter. | |||
There was a problem hiding this comment.
can we name this resourceWithHooks?
"element" is a term we've never used before and I think "resource" is more consistent: https://www.notion.so/latticexyz/MUD-naming-conventions-terminology-66e11356a1934465b2aa1a951c61a299
| @@ -52,7 +52,7 @@ contract World is StoreData, IWorldKernel { | |||
| /** | |||
| * @dev Prevents the World contract from calling itself. | |||
| */ | |||
| modifier requireNoCallback() { | |||
There was a problem hiding this comment.
not blocking but I feel like we could expand the docs here to explain why this modifier is here and important to be used, esp since this relates to a now-fixed vulnerability
|
should prob add a changeset for this one since the modifier name changed |
No description provided.