Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): Failed to get EIP-1559 fee #2079

Closed
wants to merge 1 commit into from

Conversation

aLIEzsss4
Copy link
Contributor

Fixing networks that do not support EIP-1559 fees

Fixing networks that do not support EIP-1559 fees
Copy link

changeset-bot bot commented Dec 21, 2023

⚠️ No Changeset found

Latest commit: 3dc0ec4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@holic
Copy link
Member

holic commented Dec 21, 2023

We unfortunately can't apply this everywhere. We'll have to find a way to detect when its appropriate to send legacy transactions and then conditionally add the flag.

@holic holic marked this pull request as draft December 21, 2023 18:24
@aLIEzsss4
Copy link
Contributor Author

maybe we can determine whether to add a flag parseTransaction.

@holic
Copy link
Member

holic commented Mar 11, 2024

I think the original motivation for this is the determinstic deployer we added requires being able to run replayable transactions, where some chains have replay protection turned on.

This should be fixed by #2261, so going to close this for now!

@holic holic closed this Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants