-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(store,world): remove unused imports [N-05] #2028
Conversation
🦋 Changeset detectedLatest commit: ec10366 The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we double check if all unused imports are gone? seems like the number of imports from the report and the ones removed here doesn't match
Import STORE_VERSION of StoreRead.sol
Import SliceLib of TightCoder.sol
Import FunctionSelectors of SystemCall.sol
Import IStore, Schema, System, ROOT_NAMESPACE, ROOT_NAME, revertWithBytes, NamespaceOwner, IDelegationControl, Systems, and SystemHooks of World.sol
Import ROOT_NAMESPACE, IBaseWorld, ResourceId, WorldResourceIdLib, WorldResourceIdInstance, RESOURCE_SYSTEM, AccessManagementSystem, BalanceTransferSystem, BatchCallSystem, ModuleInstallationSystem, and StoreRegistrationSystem of CoreModule.sol
Import IModule, WorldResourceIdLib, and InstalledModules of AccessManagementSystem.sol
Import WorldResourceIdLib of BalanceTransferSystem.sol
Import AccessControl and ResourceAccess of ModuleInstallationSystem.sol
Import ROOT_NAMESPACE, WorldContextProviderLib, NamespaceOwner, ResourceAccess, SystemHooks, SystemRegistry, and FunctionSelectors of StoreRegistrationSystem.sol
Import IDelegationControl of WorldRegistrationSystem.sol
Import DecodeSlice of Slice.sol
@alvrs removing the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Removes unused imports as reported by the audit, expect for
removing this one causes issues with files that use
SliceLib
.