fix(store): emit event after calling beforeSetRecord hook [L-02] #2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ea87f34 The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
alvrs
reviewed
Jan 2, 2024
alvrs
approved these changes
Jan 3, 2024
alvrs
requested changes
Jan 3, 2024
alvrs
reviewed
Jan 5, 2024
Comment on lines
-586
to
-588
| // Emit event to notify indexers | ||
| emit Store_DeleteRecord(tableId, keyTuple); | ||
|
|
There was a problem hiding this comment.
we also need to move the early return for offchain tables below the event emission, otherwise there is no event emitted for offchain tables (and the onBefore hook is not triggered)
There was a problem hiding this comment.
can we add a test for this to make sure we don't regress?
There was a problem hiding this comment.
Added a couple tests
holic
reviewed
Jan 12, 2024
holic
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rearranges
setRecord,spliceStaticData, and_spliceDynamicDatainStoreCoreto emit the storage event after calling thebeforeSetRecordhook, ensuring that storage events are emitted in the same order that values are stored on-chain.An important side-effect is that off-chain tables also early return after the hook, which means they can now use theEDIT: registering before hooks for offchain tables is explicitly not allowed so this is a no-opbeforeSetRecordhook. I think this is okay because hooks do not necessarily need to read the current storage; they can just react to the new value.