Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(world,world-modules): requireInterface correctly specifies ERC165 [M-02] #2016

Merged
merged 5 commits into from
Jan 3, 2024

Conversation

yonadaa
Copy link
Contributor

@yonadaa yonadaa commented Dec 5, 2023

Adds the ERC165Checker library to properly query support of an interface declared via IERC165.

@yonadaa yonadaa requested review from alvrs and holic as code owners December 5, 2023 12:54
Copy link

changeset-bot bot commented Dec 5, 2023

🦋 Changeset detected

Latest commit: 9ac208b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
@latticexyz/world Patch
@latticexyz/cli Patch
@latticexyz/dev-tools Patch
@latticexyz/store-sync Patch
@latticexyz/world-modules Patch
@latticexyz/store-indexer Patch
@latticexyz/abi-ts Patch
@latticexyz/block-logs-stream Patch
@latticexyz/common Patch
@latticexyz/config Patch
create-mud Patch
@latticexyz/ecs-browser Patch
@latticexyz/faucet Patch
@latticexyz/gas-report Patch
@latticexyz/network Patch
@latticexyz/noise Patch
@latticexyz/phaserx Patch
@latticexyz/protocol-parser Patch
@latticexyz/react Patch
@latticexyz/recs Patch
@latticexyz/schema-type Patch
@latticexyz/services Patch
@latticexyz/solecs Patch
solhint-config-mud Patch
solhint-plugin-mud Patch
@latticexyz/std-client Patch
@latticexyz/std-contracts Patch
@latticexyz/store-cache Patch
@latticexyz/store Patch
@latticexyz/utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

alvrs
alvrs previously approved these changes Jan 3, 2024
Copy link
Member

@alvrs alvrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, let's add a small changeset and update the gas report after merging/rebasing on latest main

@alvrs alvrs merged commit 1a0fa79 into main Jan 3, 2024
11 checks passed
@alvrs alvrs deleted the yonadaaa/require-interface-correct-specification branch January 3, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants