Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(store-indexer,faucet): enable fastify compression #1988

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

holic
Copy link
Member

@holic holic commented Dec 1, 2023

I had tried this before and was seeing a latency/response time increase but after testing this again with logger: true, I'm not seeing any response time differences. (Unclear if the response time is computed after first byte or last byte)

This is probably not the most efficient way to compress response payloads, but we're no longer running these with nginx in front so the easy option is not within reach. This should probably be made configurable, but will save that for later.

Copy link

changeset-bot bot commented Dec 1, 2023

⚠️ No Changeset found

Latest commit: 3c4113d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@holic holic marked this pull request as ready for review December 1, 2023 10:55
@holic holic requested a review from alvrs as a code owner December 1, 2023 10:55
@holic holic merged commit 6bae338 into main Dec 1, 2023
11 checks passed
@holic holic deleted the holic/indexer-compress branch December 1, 2023 13:19
@holic
Copy link
Member Author

holic commented Dec 4, 2023

fwiw this didn't work because the trpc middleware does its own stuff

that said, looks like we can pass in a middleware to do compression there too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants