-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(world-modules): add gas reports to ERC721Module #1966
Conversation
|
Thank you! Be sure to run |
yes, of course, that's what I wanted to do, but for some reason my commands are not executed. At the same time, it is clearly indicated that the process is completed and no errors have occurred. I executed commands both in the root directory and in the world-modules folder, and deleted them as well.a json file, but all attempts are in vain. Maybe you have any thoughts what am I doing wrong? |
ohh I see what's going on! these are all fuzz tests, so logs are suppressed (because each one runs hundreds if not thousands of times) and therefore gas report logs are not showing up I assume we'll need to add a separate test suite specifically for these gas reports that runs each test once |
Oh, I get it, is there anything I can help you with? |
Yeah! If you leave the gas tests where they are and a set of separate test methods that call out to the fuzzed ones with hardcoded arguments, that should give you logs/gas reports for each. For example: function testMintGas() public {
testMint(1, vm.addr("minter"));
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
closes #1854