fix(react): trigger useComponentValue on deleted records #1959
Conversation
🦋 Changeset detectedLatest commit: bc8d0f0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| @@ -33,7 +33,7 @@ export function useComponentValue<S extends Schema>( | |||
| setValue(entity != null ? getComponentValue(component, entity) : undefined); | |||
| if (entity == null) return; | |||
|
|
|||
| const queryResult = defineQuery([Has(component)], { runOnInit: false }); | |||
| const queryResult = defineQuery([Has(component)], { runOnInit: true }); | |||
There was a problem hiding this comment.
do we know if this works for adding/deleting records after the initial delete? I suspect this might just help with the first one, but I could be wrong
There was a problem hiding this comment.
The fix still has useComponentValue update if the same record is added after they're deleted. In MUDv1 where the issue had already existed, the issue happened when a record that already existed on init was then deleted, which useComponentValue didn't update without { runOnInit: true }. If a record didn't already exist upon init, was created, and then deleted, then the hook correctly updated even without the fix.
There was a problem hiding this comment.
do you wanna see if you can wire up a test to show this behavior and so we don't regress on this?
holic
changed the title
useComponentValuedoesn't trigger when record is deleted #1857 when deleting records