-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): link and deploy public libraries #1910
Conversation
🦋 Changeset detectedLatest commit: bcc2f28 The changes in this PR will be included in the next version bump. This PR includes changesets to release 31 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
9b42d37
to
ad187a2
Compare
@@ -9,18 +9,21 @@ export const defaultModuleContracts = [ | |||
name: "KeysWithValueModule", | |||
abi: KeysWithValueModuleData.abi as Abi, | |||
bytecode: KeysWithValueModuleData.bytecode.object as Hex, | |||
placeholders: [], // TODO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this TODO? I can see us revisiting this and not knowing what we need "to do"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will clarify! this isn't used/needed right now but would need to be filled in if these modules ever start using public libs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
went ahead and just moved out the placeholder logic so I could reuse it here: 4fea2b3
4fea2b3
to
0e5730c
Compare
fixes #1911