Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(faucet,store-indexer): build binaries as full bundles #1897

Closed
wants to merge 5 commits into from

Conversation

holic
Copy link
Member

@holic holic commented Nov 10, 2023

  • adds separate tsup.config.ts for bin dirs that builds each file as a full bundle (deps included)
  • adds command to build/clean bins

just a note that dev script won't watch these yet (since these are generally run with tsx locally instead of the file in dist/bin) and unclear how to run multiple dev runners/watchers with our current setup (and tsup doesn't let us configure each entrypoint individually)

Copy link

changeset-bot bot commented Nov 10, 2023

⚠️ No Changeset found

Latest commit: 9f835db

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@holic
Copy link
Member Author

holic commented Nov 10, 2023

fixed well enough in #1900

@holic holic closed this Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant