Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(cli): add faucet to newdocs #1879

Merged
merged 5 commits into from
Nov 13, 2023
Merged

docs(cli): add faucet to newdocs #1879

merged 5 commits into from
Nov 13, 2023

Conversation

qbzzt
Copy link
Contributor

@qbzzt qbzzt commented Nov 8, 2023

No description provided.

@qbzzt qbzzt requested review from alvrs and holic as code owners November 8, 2023 01:28
Copy link

changeset-bot bot commented Nov 8, 2023

⚠️ No Changeset found

Latest commit: f703f48

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@alvrs alvrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to update the mud faucet CLI to use the new faucet service (#1893) - we could still merge this but put a warning on top (bc we're gonna shut down the test network mentioned here soon and don't have the old faucet service deployed to the new test network) or we wait with merging this until we have the new faucet CLI

@qbzzt
Copy link
Contributor Author

qbzzt commented Nov 10, 2023

This will be useless until we merge the new mud faucet command itself. I think this should turn into a "coming soon", with the real content commented out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants