Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(store): resolveUserTypes for static arrays #1876

Merged
merged 6 commits into from
Nov 7, 2023
Merged

Conversation

dk1a
Copy link
Contributor

@dk1a dk1a commented Nov 7, 2023

fixes #1875

Copy link

changeset-bot bot commented Nov 7, 2023

🦋 Changeset detected

Latest commit: 3d77eff

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
@latticexyz/schema-type Major
@latticexyz/store Major
@latticexyz/cli Major
@latticexyz/common Major
@latticexyz/config Major
@latticexyz/protocol-parser Major
@latticexyz/recs Major
@latticexyz/store-sync Major
@latticexyz/world-modules Major
@latticexyz/world Major
@latticexyz/dev-tools Major
@latticexyz/react Major
@latticexyz/store-indexer Major
@latticexyz/block-logs-stream Major
@latticexyz/abi-ts Major
create-mud Major
@latticexyz/ecs-browser Major
@latticexyz/faucet Major
@latticexyz/gas-report Major
@latticexyz/network Major
@latticexyz/noise Major
@latticexyz/phaserx Major
@latticexyz/services Major
@latticexyz/solecs Major
solhint-config-mud Major
solhint-plugin-mud Major
@latticexyz/std-client Major
@latticexyz/std-contracts Major
@latticexyz/store-cache Major
@latticexyz/utils Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

holic
holic previously approved these changes Nov 7, 2023
Copy link
Member

@holic holic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a small nit around logic and type narrowing but otherwise lgtm!

holic
holic previously approved these changes Nov 7, 2023
@holic holic changed the title fix(store): fix resolveUserTypes for static arrays fix(store) resolveUserTypes for static arrays Nov 7, 2023
@holic holic changed the title fix(store) resolveUserTypes for static arrays fix(store): resolveUserTypes for static arrays Nov 7, 2023
@dk1a dk1a merged commit bb91eda into main Nov 7, 2023
12 checks passed
@dk1a dk1a deleted the dk1a/resolveUserTypes branch November 7, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deploy breaks for static-length arrays
2 participants