Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(world-modules): add gas reports to ERC721Module #1867

Closed
wants to merge 1 commit into from
Closed

feat(world-modules): add gas reports to ERC721Module #1867

wants to merge 1 commit into from

Conversation

intldds
Copy link

@intldds intldds commented Nov 2, 2023

closes #1854

@intldds intldds requested review from alvrs and holic as code owners November 2, 2023 17:45
Copy link

changeset-bot bot commented Nov 2, 2023

⚠️ No Changeset found

Latest commit: 994887a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@alvrs
Copy link
Member

alvrs commented Nov 2, 2023

Thanks for the PR. Could you elaborate on your choice of gas reports here?

@alvrs
Copy link
Member

alvrs commented Nov 2, 2023

closing this for now, feel free to reopen with gas reports more relevant for ERC721 (e.g. transferFrom, etc)

@alvrs alvrs closed this Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add gas reports to ERC721Module
2 participants