Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: switch to hardhat solidity vscode extension #1823

Merged
merged 2 commits into from
Oct 24, 2023

Conversation

holic
Copy link
Member

@holic holic commented Oct 24, 2023

  • updates to hardhat solidity plugin for speed
  • removes juanblanco-specific settings
  • updates remappings because hardhat solidity didn't like the ./ path

@changeset-bot
Copy link

changeset-bot bot commented Oct 24, 2023

⚠️ No Changeset found

Latest commit: 729361f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@holic holic changed the title chore: update remappings for hardhat vscode chore: switch to hardhat solidity Oct 24, 2023
"solidity.monoRepoSupport": true,
"solidity.compileUsingRemoteVersion": "v0.8.21+commit.d9974bed"
}
{}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left the files in case we wanted to add some defaults but could also remove if you prefer

@holic holic marked this pull request as ready for review October 24, 2023 16:37
@holic holic requested a review from alvrs as a code owner October 24, 2023 16:37
@holic holic changed the title chore: switch to hardhat solidity chore: switch to hardhat solidity vscode extension Oct 24, 2023
holic added a commit that referenced this pull request Oct 24, 2023
@holic holic merged commit 0671b4b into main Oct 24, 2023
13 checks passed
@holic holic deleted the holic/fix-hardhat-vscode-remappings branch October 24, 2023 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants